pgsql: pg_combinebackup: Fix incorrect tablespace handling.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_combinebackup: Fix incorrect tablespace handling.
Date: 2024-04-19 17:42:12
Message-ID: E1rxsFX-002rha-I8@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_combinebackup: Fix incorrect tablespace handling.

The previous coding mangled the pathname calculation for
incremental files located in user-defined tablespaces.

Enhance the test cases to cover such cases, as I should have
done originally. Thanks to Andres Freund for alerting me to the
lack of test coverage.

Discussion: http://postgr.es/m/CA+TgmoYdXTjo9iQeoipTccDpWZzvBNS6EndY2uARM+T4yG_yDg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cd64dc42d1e1b03e57e6ba3d316e4f9dec52a78d

Modified Files
--------------
src/bin/pg_combinebackup/pg_combinebackup.c | 2 +-
src/bin/pg_combinebackup/reconstruct.c | 7 ++---
src/bin/pg_combinebackup/t/002_compare_backups.pl | 32 ++++++++++++++++++++---
3 files changed, 33 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2024-04-19 19:59:38 pgsql: Use tempdir_short instead of tempdir.
Previous Message Robert Haas 2024-04-19 17:29:53 pgsql: Make PostgreSQL::Test::Cluster::init_from_backup handle tablespa