From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Refactor pipe_read_line to return the full line |
Date: | 2024-02-09 14:25:15 |
Message-ID: | E1rYRoZ-005P24-Cx@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Refactor pipe_read_line to return the full line
Commit 5b2f4afffe6 refactored find_other_exec() and in the process
created pipe_read_line() into a static routine for reading a single
line of output, aimed at reading version numbers. Commit a7e8ece41
later exposed it externally in order to read a postgresql.conf GUC
using "postgres -C ..". Further, f06b1c598 also made use of it for
reading a version string much like find_other_exec(). The internal
variable remained "pgver", even when used for other purposes.
Since the function requires passing a buffer and its size, and at
most size - 1 bytes will be read via fgets(), there is a truncation
risk when using this for reading GUCs (like how pg_rewind does,
though the risk in this case is marginal).
To keep this as generic functionality for reading a line from a pipe,
this refactors pipe_read_line() into returning an allocated buffer
containing all of the line to remove the risk of silent truncation.
Reviewed-by: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Reviewed-by: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Reviewed-by: John Naylor <johncnaylorls(at)gmail(dot)com>
Discussion: https://postgr.es/m/DEDF73CE-D528-49A3-9089-B3592FD671A9@yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5c7038d70bb9c4d28a80b0a2051f73fafab5af3f
Modified Files
--------------
src/bin/pg_rewind/pg_rewind.c | 14 ++++++--------
src/bin/pg_upgrade/exec.c | 6 ++++--
src/common/exec.c | 39 +++++++++++++++++++++++++--------------
src/include/port.h | 2 +-
4 files changed, 36 insertions(+), 25 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2024-02-09 16:21:22 | pgsql: Clean up Windows-specific mutex code in libpq and ecpglib. |
Previous Message | Alexander Korotkov | 2024-02-09 11:09:07 | pgsql: Fix usage of aggregate pathkeys in group_keys_reorder_by_pathkey |