From: | Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix usage of aggregate pathkeys in group_keys_reorder_by_pathkey |
Date: | 2024-02-09 11:09:07 |
Message-ID: | E1rYOkl-005Ndr-A2@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix usage of aggregate pathkeys in group_keys_reorder_by_pathkeys()
group_keys_reorder_by_pathkeys() function searched for matching pathkeys
within root->group_pathkeys. That could lead to picking an aggregate pathkey
and using its pathkey->pk_eclass->ec_sortref as an argument of
get_sortgroupref_clause_noerr(). Given that ec_sortref of an aggregate pathkey
references aggregate targetlist not query targetlist, this leads to incorrect
query optimization.
Fix this by looking for matching pathkeys only within the first
num_groupby_pathkeys pathkeys.
Reported-by: David G. Johnston
Discussion: https://postgr.es/m/CAKFQuwY3Ek%3DcLThgd8FdaSc5JRDVt0FaV00gMcWra%2BTAR4gGUw%40mail.gmail.com
Author: Andrei Lepikhov, Alexander Korotkov
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c01f6ef46c8f0ab3faa54e8f040da6e9ddc7fe5b
Modified Files
--------------
src/backend/optimizer/path/pathkeys.c | 25 +++++++++++++++++++++----
src/test/regress/expected/aggregates.out | 24 ++++++++++++++++++++++++
src/test/regress/sql/aggregates.sql | 19 +++++++++++++++++++
3 files changed, 64 insertions(+), 4 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2024-02-09 14:25:15 | pgsql: Refactor pipe_read_line to return the full line |
Previous Message | Alexander Korotkov | 2024-02-09 10:55:56 | pgsql: Fix wrong logic in TransactionIdInRecentPast() |