pgsql: Enhance checkpointer restartpoint statistics

From: Alexander Korotkov <akorotkov(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Enhance checkpointer restartpoint statistics
Date: 2023-12-24 23:13:11
Message-ID: E1rHXeg-00Bl0i-Uw@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Enhance checkpointer restartpoint statistics

Bhis commit introduces enhancements to the pg_stat_checkpointer view by adding
three new columns: restartpoints_timed, restartpoints_req, and
restartpoints_done. These additions aim to improve the visibility and
monitoring of restartpoint processes on replicas.

Previously, it was challenging to differentiate between successful and failed
restartpoint requests. This limitation arises because restartpoints on replicas
are dependent on checkpoint records from the primary, and cannot occur more
frequently than these checkpoints.

The new columns allow for clear distinction and tracking of restartpoint
requests, their triggers, and successful completions. This enhancement aids
database administrators and developers in better understanding and diagnosing
issues related to restartpoint behavior, particularly in scenarios where
restartpoint requests may fail.

System catalog is changed. Catversion is bumped.

Discussion: https://postgr.es/m/99b2ccd1-a77a-962a-0837-191cdf56c2b9%40inbox.ru
Author: Anton A. Melnikov
Reviewed-by: Kyotaro Horiguchi, Alexander Korotkov

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/12915a58eec962f407a6c38ce2bf08a48dde57b5

Modified Files
--------------
doc/src/sgml/monitoring.sgml | 27 ++++++++++++++++
doc/src/sgml/wal.sgml | 39 ++++++++++++++++++++----
src/backend/catalog/system_views.sql | 3 ++
src/backend/postmaster/checkpointer.c | 27 ++++++++++++++--
src/backend/utils/activity/pgstat_checkpointer.c | 6 ++++
src/backend/utils/adt/pgstatfuncs.c | 18 +++++++++++
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.dat | 15 +++++++++
src/include/pgstat.h | 3 ++
src/test/regress/expected/rules.out | 3 ++
10 files changed, 134 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2023-12-24 23:33:56 pgsql: Don't constrain self-join removal due to PHVs
Previous Message Michael Paquier 2023-12-24 02:52:37 pgsql: pgbench: Fix overflow in table populating when rows >= 2^31-1