pgsql: pgbench: Fix overflow in table populating when rows >= 2^31-1

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pgbench: Fix overflow in table populating when rows >= 2^31-1
Date: 2023-12-24 02:52:37
Message-ID: E1rHEbV-00Bdsg-Bp@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pgbench: Fix overflow in table populating when rows >= 2^31-1

Using a scale factor large enough so as the number of rows to insert
gets larger than INT32_MAX would cause an infinite loop in
initPopulateTable(), preventing pgbench to finish its initialization.

Oversight in e35cc3b3f2d0 that has refactored the data generation logic.

Author: John Hsu
Reviewed-by: Tatsuo Ishii, Japin Li
Discussion: https://postgr.es/m/CA+-JvFvHsOafjHcuFPfkyouHNZvbOXhBNhwZxKm3WNgYz9bwzA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/64e77b496af61ee31189ba69b40e785e11e9967f

Modified Files
--------------
src/bin/pgbench/pgbench.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2023-12-24 23:13:11 pgsql: Enhance checkpointer restartpoint statistics
Previous Message Michael Paquier 2023-12-24 02:30:21 Re: pgsql: Prevent tuples to be marked as dead in subtransactions on standb