| From: | Jeff Davis <jdavis(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Additional write barrier in AdvanceXLInsertBuffer(). |
| Date: | 2023-12-20 01:44:29 |
| Message-ID: | E1rFldM-00B0Kl-K5@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Additional write barrier in AdvanceXLInsertBuffer().
First, mark the xlblocks member with InvalidXLogRecPtr, then issue a
write barrier, then initialize it. That ensures that the xlblocks
member doesn't appear valid while the contents are being initialized.
In preparation for reading WAL buffer contents without a lock.
Author: Bharath Rupireddy
Discussion: https://postgr.es/m/CALj2ACVfFMfqD5oLzZSQQZWfXiJqd-NdX0_317veP6FuB31QWA@mail.gmail.com
Reviewed-by: Andres Freund
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/766571be16598b401b5527208847145edc6be1f4
Modified Files
--------------
src/backend/access/transam/xlog.c | 8 ++++++++
1 file changed, 8 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2023-12-20 02:16:55 | Re: pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common. |
| Previous Message | Michael Paquier | 2023-12-20 01:01:16 | Re: pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common. |