From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common. |
Date: | 2023-12-20 02:16:55 |
Message-ID: | CA+TgmoY16544sFZQbe1Wrdzt0-4FxfQ=xMDwO7m-bXX+YJ-Xew@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Tue, Dec 19, 2023 at 8:01 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Dec 19, 2023 at 08:29:18PM +0000, Robert Haas wrote:
> > Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
> >
> > This makes it possible for the code to be easily reused by other
> > client-side tools, and/or by the server.
> >
> > Patch by me. Review of this patch in particular by at least Peter
> > Eisentraut; reviewers for the patch series in general include Dilip
> > Kumar, Andres Fruend, David Steele, Álvaro Herrera, and Jakub Wartak.
>
> Worth noting that this has forgotten to update @pgcommonallfiles in
> Mkvcbuild.pm so this would have failed a build with src/build/msvc/.
> Or you counted on me here, relying on the scripts to be gone? ;p
To be honest, I counted on CI to tell me whether it still builds everywhere.
--
Robert Haas
EDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2023-12-20 06:08:19 | pgsql: Fix generation of distribution tarball |
Previous Message | Jeff Davis | 2023-12-20 01:44:29 | pgsql: Use 64-bit atomics for xlblocks array elements. |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2023-12-20 02:32:33 | Re: "pgoutput" options missing on documentation |
Previous Message | Thomas wen | 2023-12-20 01:58:47 | 回复: Transaction timeout |