pgsql: Don't clean initdb files on template creation failure

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Don't clean initdb files on template creation failure
Date: 2023-12-08 12:48:43
Message-ID: E1rBaHb-009CQg-H4@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't clean initdb files on template creation failure

Commit 252dcb32397f6 introduced initdb template caching to speed up
tests by re-using initdb output. The initdb command didn't however
use the --no-clean option to preserve generated data in case initdb
crashes unlike pg_regress which does do this. This adds the option
to initdb to aid debugging.

While changing the commandline, switch to using long options for
initdb to make the code more self-documenting.

Author: Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAEze2WhSTjfK_M+Ea4GSQp8odrEOaQS8HyORd1TJUEiyXaB+rw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/00edb2061fcf288574b7b5c0be67fab71f7e136b

Modified Files
--------------
meson.build | 3 ++-
src/Makefile.global.in | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-12-08 13:38:23 Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining
Previous Message Heikki Linnakangas 2023-12-08 11:22:56 pgsql: Remove some unnecessary #includes of postmaster/interrupt.h