| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining |
| Date: | 2023-12-08 13:38:23 |
| Message-ID: | 82CD6B67-1B7C-4D4B-9533-A94A2E4BC15B@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
> On 20 Nov 2023, at 22:53, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 19 Nov 2023, at 21:08, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> I'll have a look with fresh eyes in the morning, and hopefully it will be
>> fixable. If it get's messy it's quite possible that skipping v12 is the best
>> option.
>
> As an update, discussing with Andres off-list I have a potential patch for
> this, need to rebuild LLVM debug builds tomorrow to test further but there
> should be either a fix or a revert soon.
After some more work with Andres, the bug was found to be a void pointer not
created in the referenced context. The attached diff fixes the issue (which is
related to code refactored in v13 hence why it only affects v12). I will apply
that to v12 shortly after a little more testing.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| llvmcontext_v12_fix.diff | application/octet-stream | 901 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2023-12-08 16:15:56 | pgsql: Add empty BRIN ranges during CREATE INDEX |
| Previous Message | Daniel Gustafsson | 2023-12-08 12:48:43 | pgsql: Don't clean initdb files on template creation failure |