pgsql: Fix off-by-one in XLogRecordMaxSize check.

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix off-by-one in XLogRecordMaxSize check.
Date: 2023-08-12 21:38:29
Message-ID: E1qUwJY-001kru-Ix@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix off-by-one in XLogRecordMaxSize check.

pg_logical_emit_message(false, '_', repeat('x', 1069547465)) failed with
self-contradictory message "WAL record would be 1069547520 bytes (of
maximum 1069547520 bytes)". There's no particular benefit from allowing
or denying one byte in either direction; XLogRecordMaxSize could rise a
few megabytes without trouble. Hence, this is just for cleanliness.
Back-patch to v16, where this check first appeared.

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7823a298ba5c54a67f98c928f73500bc4089449f

Modified Files
--------------
src/backend/access/transam/xloginsert.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2023-08-12 22:12:33 pgsql: ci: macos: Remove use of -DRANDOMIZE_ALLOCATED_MEMORY
Previous Message Michael Paquier 2023-08-12 01:47:49 pgsql: Show GIDs of two-phase commit commands as constants in pg_stat_s