pgsql: Show GIDs of two-phase commit commands as constants in pg_stat_s

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Show GIDs of two-phase commit commands as constants in pg_stat_s
Date: 2023-08-12 01:47:49
Message-ID: E1qUdjI-001cmJ-N9@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Show GIDs of two-phase commit commands as constants in pg_stat_statements

This relies on the "location" field added to TransactionStmt in 31de7e6,
now applied to the "gid" field used by 2PC commands. These commands are
now reported like:
COMMIT PREPARED $1
PREPARE TRANSACTION $1
ROLLBACK PREPARED $1

Applying constants for these commands is a huge advantage for workloads
that rely a lot on 2PC commands with different GIDs. Some tests are
added to track the new behavior.

Reviewed-by: Julien Rouhaud
Discussion: https://postgr.es/m/ZMhT9kNtJJsHw6jK@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/638d42a3c52081cf4882520f0622161bad69b40f

Modified Files
--------------
contrib/pg_stat_statements/expected/utility.out | 23 ++++++++++++++++++++++
contrib/pg_stat_statements/pg_stat_statements.conf | 1 +
contrib/pg_stat_statements/sql/utility.sql | 10 ++++++++++
src/backend/parser/gram.y | 6 +++---
src/include/nodes/parsenodes.h | 3 ++-
5 files changed, 39 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2023-08-12 21:38:29 pgsql: Fix off-by-one in XLogRecordMaxSize check.
Previous Message Michael Paquier 2023-08-11 11:49:03 pgsql: Fix code indentation violations introduced by recent commit