| From: | Amit Kapila <akapila(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Add BEGIN/COMMIT for transactional messages during decoding. |
| Date: | 2023-07-11 03:03:15 |
| Message-ID: | E1qJ3el-002v1x-BL@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Add BEGIN/COMMIT for transactional messages during decoding.
In test_decoding module, when skip_empty_xacts option was specified, add
BEGIN/COMMIT for transactional messages. This makes the handling of
transactional messages consistent irrespective of whether skip_empty_xacts
option was specified.
We decided not to backpatch this change because skip_empty_xacts is
primarily used to have consistent test results across different runs and
this change won't help with that.
Author: Vignesh C
Reviewed-by: Ashutosh Bapat, Hou Zhijie
Discussion: https://postgr.es/m/CAExHW5ujRhbOz6_aTq_jQA8NjeFqq9d_8G9viShWvXx8gdSXiQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/26dd0284b98f6bf730dc1f7f7e1f917525d71eda
Modified Files
--------------
contrib/test_decoding/expected/messages.out | 10 ++++++++--
contrib/test_decoding/sql/messages.sql | 2 +-
contrib/test_decoding/test_decoding.c | 12 ++++++++++++
3 files changed, 21 insertions(+), 3 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2023-07-11 03:36:32 | pgsql: Add new parallel message type to progress reporting. |
| Previous Message | Thomas Munro | 2023-07-10 21:52:37 | pgsql: Don't expose Windows' mbstowcs_l() and wcstombs_l(). |