From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Don't expose Windows' mbstowcs_l() and wcstombs_l(). |
Date: | 2023-07-10 21:52:37 |
Message-ID: | E1qIyo9-002sxw-8J@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Don't expose Windows' mbstowcs_l() and wcstombs_l().
Windows has similar functions with leading underscores. Previously, we
provided the rename via a macro in win32_port.h. In fact its functions
are not always good replacements for the Unix functions, since they
can't deal with UTF-8. They are only currently used by pg_locale.c,
which is careful to redirect to other Windows routines for UTF-8. Given
that portability hazard, it seem unlikely to be a good idea to encourage
any other code to think of these functions as being available outside
pg_locale.c. Any code that thinks it wants these functions probably
wants our wchar2char() or char2wchar() routines instead, or it won't
actually work on Windows in UTF-8 databases.
Furthermore, some major libc implementations including glibc don't have
them (they only have the standard variants without _l), so external code
is very unlikely to require them to exist.
Reviewed-by: Peter Eisentraut <peter(at)eisentraut(dot)org>
Discussion: https://postgr.es/m/CA%2BhUKG%2Bt_CHPzEoPnKyARJBJgE9-GxNajJo6ZuSfRK_KWFO%2B6w%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4e9fa6d56b3e4e1b6238fb24200e6baece229401
Modified Files
--------------
src/backend/utils/adt/pg_locale.c | 13 +++++++++----
src/include/port/win32_port.h | 2 --
2 files changed, 9 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2023-07-11 03:03:15 | pgsql: Add BEGIN/COMMIT for transactional messages during decoding. |
Previous Message | Tom Lane | 2023-07-10 16:14:51 | pgsql: Be more rigorous about local variables in PostgresMain(). |