From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Silence "missing contrecord" error. |
Date: | 2023-07-02 23:29:21 |
Message-ID: | E1qG6VN-001bZR-L5@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Silence "missing contrecord" error.
Commit dd38ff28ad added a new error message "missing contrecord" when
we fail to reassemble a record. Unfortunately that caused noisy
messages to be logged by pg_waldump at end of segment, and by walsender
when asked to shut down on a segment boundary.
Remove the new error message, so that this condition signals end-of-
WAL without a message. It's arguably a reportable condition that should
not be silenced while performing crash recovery, but fixing that without
introducing noise in the other cases will require more research.
Back-patch to 15.
Reported-by: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Discussion: https://postgr.es/m/6a1df56e-4656-b3ce-4b7a-a9cb41df8189%40enterprisedb.com
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f50200c0163c1dbb5aa015828e8bf32b50a2cd29
Modified Files
--------------
src/backend/access/transam/xlogreader.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2023-07-03 00:22:58 | Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass |
Previous Message | Thomas Munro | 2023-07-02 23:29:11 | pgsql: Silence "missing contrecord" error. |