pgsql: Fix CREATE DATABASE so we can pg_upgrade DBs with OIDs above 2^3

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix CREATE DATABASE so we can pg_upgrade DBs with OIDs above 2^3
Date: 2022-11-04 14:40:03
Message-ID: E1oqxrY-000PdT-70@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix CREATE DATABASE so we can pg_upgrade DBs with OIDs above 2^31.

Commit aa0105141 repeated one of the oldest mistakes in our book:
thinking that OID is the same as int32. It isn't of course, and
unsurprisingly the first person who came along with a database
OID above 2 billion broke it. Repair.

Per bug #17677 from Sergey Pankov. Back-patch to v15.

Discussion: https://postgr.es/m/17677-a99fa067d7ed71c9@postgresql.org

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2c6d43650d16d91a3e731d236315beffd98db729

Modified Files
--------------
src/backend/commands/dbcommands.c | 2 +-
src/backend/commands/define.c | 33 +++++++++++++++++++++++++++++++++
src/backend/parser/gram.y | 4 ++--
src/include/commands/defrem.h | 1 +
4 files changed, 37 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Justin Pryzby 2022-11-04 16:19:35 Re: pgsql: Resolve partition strategy during early parsing
Previous Message Etsuro Fujita 2022-11-04 10:31:16 pgsql: Correct error message for row-level triggers with transition tab