Re: pgsql: Resolve partition strategy during early parsing

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Resolve partition strategy during early parsing
Date: 2022-11-04 16:19:35
Message-ID: 20221104161934.GB16921@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Nov 03, 2022 at 03:41:56PM +0000, Alvaro Herrera wrote:
> Resolve partition strategy during early parsing
>
> This has little practical value, but there's no reason to let the
> partition strategy names travel through DDL as strings.
>
> Reviewed-by: Japin Li <japinli(at)hotmail(dot)com>
> Discussion: https://postgr.es/m/20221021093216.ffupd7epy2mytkux@alvherre.pgsql
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/5fca91025e05f803140831953c09a36f08efcef5

This caused a warning in MSVC.

[16:10:46.225] c:\cirrus\src\backend\parser\gram.y(18435) : warning C4715: 'parsePartitionStrategy': not all control paths return a value

I'll send a patch to make cfbot warn about that soon.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-11-04 16:46:11 pgsql: First-draft release notes for 15.1.
Previous Message Tom Lane 2022-11-04 14:40:03 pgsql: Fix CREATE DATABASE so we can pg_upgrade DBs with OIDs above 2^3