pgsql: Remove race condition in 022_crash_temp_files.pl test.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove race condition in 022_crash_temp_files.pl test.
Date: 2022-04-06 00:44:14
Message-ID: E1nbtmQ-000VXf-5X@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove race condition in 022_crash_temp_files.pl test.

It's possible for the query that "waits for restart" to complete a
successful iteration before the postmaster has noticed its SIGKILL'd
child and begun the restart cycle. (This is a bit hard to believe
perhaps, but it's been seen at least twice in the buildfarm, mainly
on ancient platforms that likely have quirky schedulers.)

To provide a more secure interlock, wait for the other session
we're using to report that it's been forcibly shut down.

Patch by me, based on a suggestion from Andres Freund.
Back-patch to v14 where this test case came in.

Discussion: https://postgr.es/m/1801850.1649047827@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e37ad5fa4df2319e26a7e779607130feae1a5029

Modified Files
--------------
src/test/recovery/t/022_crash_temp_files.pl | 34 +++++++++++++++++++++++++----
1 file changed, 30 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tatsuo Ishii 2022-04-06 00:59:03 pgsql: Change aggregated log format of pgbench.
Previous Message Thom Brown 2022-04-06 00:42:48 Re: [COMMITTERS] pgsql: Allow time delayed standbys and recovery