Re: [COMMITTERS] pgsql: Allow time delayed standbys and recovery

From: Thom Brown <thom(at)linux(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Allow time delayed standbys and recovery
Date: 2022-04-06 00:42:48
Message-ID: CAA-aLv4UwYOVos3g9JWFsfOpRmxxEyxOSgAZPptLEQcXdsQPYw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, 5 Apr 2022 at 16:02, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Tue, Apr 5, 2022 at 10:58 AM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> >> Makes sense. I will do this soon if nobody objects.
> >>
> >> I'm mildly uncomfortable with the phrase "WAL records generated over
> >> the delay period" because it seems a bit imprecise, but I'm not sure
> >> what would be better and I think the meaning is clear.
> >
> > Maybe "during" instead of "over"? But I'm not sure that's the part you're referring to?
>
> Yeah, something like that, maybe.

I share your discomfort with the wording. How about:

WAL records must be kept on standby until they are ready to be applied.
Therefore, longer delays will result in a greater accumulation of WAL files,
increasing disk space requirements for the standby's <filename>pg_wal</>
directory.
--
Thom

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-04-06 00:44:14 pgsql: Remove race condition in 022_crash_temp_files.pl test.
Previous Message Daniel Gustafsson 2022-04-05 20:24:59 pgsql: Fix compilerwarning in logging size_t

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-04-06 00:46:01 Re: Race condition in server-crash testing
Previous Message Hao Wu 2022-04-05 23:27:21 Re: Enables to call Unregister*XactCallback() in Call*XactCallback()