pgsql: Split ExecUpdate and ExecDelete into reusable pieces

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Split ExecUpdate and ExecDelete into reusable pieces
Date: 2022-03-17 10:47:34
Message-ID: E1nUnfK-0006rC-8S@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Split ExecUpdate and ExecDelete into reusable pieces

Create subroutines ExecUpdatePrologue / ExecUpdateAct /
ExecUpdateEpilogue, and similar for ExecDelete.

Introduce a new struct to be used internally in nodeModifyTable.c,
dubbed ModifyTableContext, which contains all context information needed
to perform these operations, as well as ExecInsert and others.

This allows using a different schedule and a different way of evaluating
the results of these operations, which can be exploited by a later
commit introducing support for MERGE. It also makes ExecUpdate and
ExecDelete proper shorter and (hopefully) simpler.

Author: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Reviewed-by: Amit Langote <amitlangote09(at)gmail(dot)com>
Reviewed-by: Japin Li <japinli(at)hotmail(dot)com>
Reviewed-by: Zhihong Yu <zyu(at)yugabyte(dot)com>
Discussion: https://postgr.es/m/202202271724.4z7xv3cf46kv@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/25e777cf8e547d7423d2e1e9da71f98b9414d59e

Modified Files
--------------
src/backend/executor/nodeModifyTable.c | 781 ++++++++++++++++++++-------------
src/tools/pgindent/typedefs.list | 2 +
2 files changed, 484 insertions(+), 299 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2022-03-17 13:14:22 pgsql: doc: Add documentation for new field pg_database.daticulocale
Previous Message Peter Eisentraut 2022-03-17 10:22:32 pgsql: Add option to use ICU as global locale provider