pgsql: pgoutput: Fix memory leak due to RelationSyncEntry.map.

From: Amit Kapila <akapila(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pgoutput: Fix memory leak due to RelationSyncEntry.map.
Date: 2021-06-01 08:58:47
Message-ID: E1lo0EZ-0004wJ-D8@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pgoutput: Fix memory leak due to RelationSyncEntry.map.

Release memory allocated when creating the tuple-conversion map and its
component TupleDescs when its owning sync entry is invalidated.
TupleDescs must also be freed when no map is deemed necessary, to begin
with.

Reported-by: Andres Freund
Author: Amit Langote
Reviewed-by: Takamichi Osumi, Amit Kapila
Backpatch-through: 13, where it was introduced
Discussion: https://postgr.es/m/MEYP282MB166933B1AB02B4FE56E82453B64D9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eb89cb43a0d0e401e71b8e2345b5f5bc8b2755a1

Modified Files
--------------
src/backend/replication/pgoutput/pgoutput.c | 46 ++++++++++++++++++++++++-----
src/test/subscription/t/013_partition.pl | 28 +++++++++++++++++-
2 files changed, 65 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-06-01 15:13:38 pgsql: Reject SELECT ... GROUP BY GROUPING SETS (()) FOR UPDATE.
Previous Message Michael Paquier 2021-06-01 00:28:54 pgsql: Add fallback implementation for setenv()