pgsql: Add fallback implementation for setenv()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add fallback implementation for setenv()
Date: 2021-06-01 00:28:54
Message-ID: E1lnsH8-0001jK-9c@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add fallback implementation for setenv()

This fixes the code compilation on Windows with MSVC and Kerberos, as
a missing implementation of setenv() causes a compilation failure of the
GSSAPI code. This was only reproducible when building the code with
Kerberos, something that buildfarm animal hamerkop has fixed recently.

This issue only happens on 12 and 13, as this code has been introduced
in b0b39f7. HEAD is already able to compile properly thanks to
7ca37fb0, and this commit is a minimal cherry-pick of it.

Thanks to Tom Lane for the discussion.

Discussion: https://postgr.es/m/YLDtm5WGjPxm6ua4@paquier.xyz
Backpatch-through: 12

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e2f21ff606dae2f7f7a9e323a88c99b464d2f787

Modified Files
--------------
configure | 19 ++++++++++++++++-
configure.in | 4 +++-
src/include/pg_config.h.in | 3 +++
src/include/port.h | 4 ++++
src/include/port/win32_port.h | 2 ++
src/port/setenv.c | 48 +++++++++++++++++++++++++++++++++++++++++++
src/tools/msvc/Mkvcbuild.pm | 2 +-
src/tools/msvc/Solution.pm | 1 +
8 files changed, 80 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2021-06-01 08:58:47 pgsql: pgoutput: Fix memory leak due to RelationSyncEntry.map.
Previous Message Thomas Munro 2021-05-31 23:32:45 pgsql: Fix error handling in replacement pthread_barrier_init().