| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Rename the logical replication global "wrconn" |
| Date: | 2021-05-12 23:19:15 |
| Message-ID: | E1lgy8J-0000Ni-Rp@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Rename the logical replication global "wrconn"
The worker.c global wrconn is only meant to be used by logical apply/
tablesync workers, but there are other variables with the same name. To
reduce future confusion rename the global from "wrconn" to
"LogRepWorkerWalRcvConn".
While this is just cosmetic, it seems better to backpatch it all the way
back to 10 where this code appeared, to avoid future backpatching
issues.
Author: Peter Smith <smithpb2250(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAHut+Pu7Jv9L2BOEx_Z0UtJxfDevQSAUW2mJqWU+CtmDrEZVAg@mail.gmail.com
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e5c071bc0f93c9c47821c876e36459580e08a68c
Modified Files
--------------
src/backend/replication/logical/launcher.c | 4 ++--
src/backend/replication/logical/tablesync.c | 26 +++++++++++++++-----------
src/backend/replication/logical/worker.c | 21 +++++++++++----------
src/include/replication/worker_internal.h | 2 +-
4 files changed, 29 insertions(+), 24 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-05-13 01:02:44 | pgsql: Make saner the tab completion of INSERT and DELETE in psql |
| Previous Message | Tom Lane | 2021-05-12 22:41:47 | pgsql: Double-space commands in system_constraints.sql/system_functions |