pgsql: Remove overzealous VACUUM visibility map assertion.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove overzealous VACUUM visibility map assertion.
Date: 2021-05-06 20:18:17
Message-ID: E1lekRt-0004gC-5W@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove overzealous VACUUM visibility map assertion.

The all_visible_according_to_vm variable's value is inherently prone to
becoming invalidated concurrently, since it is set before we even
acquire a lock on a related heap page buffer.

Oversight in commit 7136bf34, which added the assertion in passing.

Author: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Reported-By: Tang <tanghy(dot)fnst(at)fujitsu(dot)com>
Diagnosed-By:: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAD21AoDzgc8_MYrA5m1fyydomw_eVKtQiYh7sfDK4KEhdMsf_g@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c9787385db47ba423d845b34d58e158551c6335d

Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 1 -
1 file changed, 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2021-05-06 20:43:39 pgsql: Improve documentation on DETACH PARTITION lock levels
Previous Message Alvaro Herrera 2021-05-06 17:04:08 pgsql: Track detached partitions more accurately in partdescs