pgsql: Track detached partitions more accurately in partdescs

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Track detached partitions more accurately in partdescs
Date: 2021-05-06 17:04:08
Message-ID: E1lehQ0-0003Xw-0p@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Track detached partitions more accurately in partdescs

In d6b8d29419df I (Álvaro) was sloppy about recording whether a
partition descripor does or does not include detached partitions, when
the snapshot checking does not see the pg_inherits row marked detached.
In that case no partition was omitted, yet in the relcache entry we were
saving the partdesc as omitting partitions. Flip that (so we save it as
a partdesc not omitting partitions, which indeed it doesn't), which
hopefully makes the code easier to reason about.

Author: Amit Langote <amitlangote09(at)gmail(dot)com>
Discussion: https://postgr.es/m/CA+HiwqE7GxGU4VdzwZzfiz+Ont5SsopoFkgtrZGEdPqWRL+biA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3fe773b149755977d2ffde2afd89557b39d0afd9

Modified Files
--------------
src/backend/partitioning/partdesc.c | 22 ++++++++++++++++------
src/include/utils/rel.h | 4 +---
2 files changed, 17 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2021-05-06 20:18:17 pgsql: Remove overzealous VACUUM visibility map assertion.
Previous Message Tom Lane 2021-05-06 13:59:16 pgsql: Doc: trivial wording adjustment.