From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix plpgsql tests for debug_invalidate_system_caches_always. |
Date: | 2021-01-08 23:12:15 |
Message-ID: | E1ky0vX-000568-UP@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix plpgsql tests for debug_invalidate_system_caches_always.
Commit c9d529848 resulted in having a couple more places where
the error context stack for a failure varies depending on
debug_invalidate_system_caches_always (nee CLOBBER_CACHE_ALWAYS).
This is not very surprising, since we have to re-parse cached
plans if the plan cache is clobbered. Stabilize the expected
test output by hiding the context stack in these places,
as we've done elsewhere in this test script.
(Another idea worth considering, now that we have
debug_invalidate_system_caches_always, is to force it to zero for
these test cases. That seems like it'd risk reducing the coverage
of cache-clobber testing, which might or might not be worth being
able to verify that we get the expected error output in normal
cases. For the moment I just stuck with the existing technique.)
In passing, update comments that referred to CLOBBER_CACHE_ALWAYS.
Per buildfarm member hyrax.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/39d4a153105f0693d93f593a23e5144e2bd031ef
Modified Files
--------------
src/pl/plpgsql/src/expected/plpgsql_cache.out | 8 ++++----
src/pl/plpgsql/src/expected/plpgsql_cache_1.out | 8 ++++----
src/pl/plpgsql/src/expected/plpgsql_record.out | 18 ++++++++++++------
src/pl/plpgsql/src/sql/plpgsql_cache.sql | 8 ++++----
src/pl/plpgsql/src/sql/plpgsql_record.sql | 16 ++++++++++++----
5 files changed, 36 insertions(+), 22 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-01-09 05:47:47 | Re: pgsql: Test decoding of two-phase transactions during the build of a co |
Previous Message | Tom Lane | 2021-01-08 17:16:20 | pgsql: Fix ancient bug in parsing of BRE-mode regular expressions. |