From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix fuzzy thinking about amcanmulticol versus amcaninclude. |
Date: | 2020-11-15 21:12:09 |
Message-ID: | E1kePJh-0006KA-CT@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix fuzzy thinking about amcanmulticol versus amcaninclude.
These flags should be independent: in particular an index AM should
be able to say that it supports include columns without necessarily
supporting multiple key columns. The included-columns patch got
this wrong, possibly aided by the fact that it didn't bother to
update the documentation.
While here, clarify some text about amcanreturn, which was a little
vague about what should happen when amcanreturn reports that only
some of the index columns are returnable.
Noted while reviewing the SP-GiST included-columns patch, which
quite incorrectly (and unsafely) changed SP-GiST to claim
amcanmulticol = true as a workaround for this bug.
Backpatch to v11 where included columns were introduced.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/29d29d652f0be47dc42fa9d667dee5b8e1baa18a
Modified Files
--------------
doc/src/sgml/indexam.sgml | 35 +++++++++++++++++++++++++++--------
src/backend/commands/indexcmds.c | 4 ++--
2 files changed, 29 insertions(+), 10 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-11-16 03:00:42 | pgsql: Relax INSERT privilege requirement for CTAS and matviews WITH NO |
Previous Message | Peter Geoghegan | 2020-11-15 19:54:06 | pgsql: nbtree: Demote incomplete split "can't happen" error. |