pgsql: nbtree: Demote incomplete split "can't happen" error.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: nbtree: Demote incomplete split "can't happen" error.
Date: 2020-11-15 19:54:06
Message-ID: E1keO6A-0005sQ-6K@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

nbtree: Demote incomplete split "can't happen" error.

Only a basic logic bug in a _bt_insertonpg() caller could lead to a
violation of this invariant (index corruption won't do it). A "can't
happen" error seems inappropriate (it is arbitrary at best).

Demote the error to a simple assertion. This matches similar nearby
sanity checks.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/46cf3c72c36fef8c623b4b97d8720321d8ad7507

Modified Files
--------------
src/backend/access/nbtree/nbtinsert.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-11-15 21:12:09 pgsql: Fix fuzzy thinking about amcanmulticol versus amcaninclude.
Previous Message Tom Lane 2020-11-15 17:39:55 pgsql: Suppress "warning: variable 'collcollate' set but not used".