pgsql: Check for fseeko() failure in pg_dump's _tarAddFile().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Check for fseeko() failure in pg_dump's _tarAddFile().
Date: 2020-08-09 16:39:31
Message-ID: E1k4oM7-0004MY-Is@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Check for fseeko() failure in pg_dump's _tarAddFile().

Coverity pointed out, not unreasonably, that we checked fseeko's
result at every other call site but these. Failure to seek in the
temp file (note this is NOT pg_dump's output file) seems quite
unlikely, and even if it did happen the file length cross-check
further down would probably detect the problem. Still, that's a
poor excuse for not checking the result of a system call.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1b9cde51246c7773eac119b84cc18095118735de

Modified Files
--------------
src/bin/pg_dump/pg_backup_tar.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2020-08-09 19:02:33 pgsql: Correct nbtree page split lock coupling comment.
Previous Message Tom Lane 2020-08-09 15:32:41 pgsql: Remove useless Assert.