| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove useless Assert. |
| Date: | 2020-08-09 15:32:41 |
| Message-ID: | E1k4nJR-0003wu-AB@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove useless Assert.
Testing that an unsigned variable is >= 0 is pretty pointless,
as noted by Coverity and numerous buildfarm members.
In passing, add comment about new uses of "volatile" --- Coverity
doesn't much like that either, but it seems probably necessary.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1c164ef3d28dfab445a885a03e80cfd0d552f64a
Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-08-09 16:39:31 | pgsql: Check for fseeko() failure in pg_dump's _tarAddFile(). |
| Previous Message | Tom Lane | 2020-08-09 00:02:17 | pgsql: Release notes for 12.4, 11.9, 10.14, 9.6.19, 9.5.23. |