pgsql: createdb: Fix quoting of --encoding, --lc-ctype and --lc-collate

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: createdb: Fix quoting of --encoding, --lc-ctype and --lc-collate
Date: 2020-02-27 02:23:33
Message-ID: E1j78pp-0005GG-Ao@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

createdb: Fix quoting of --encoding, --lc-ctype and --lc-collate

The original coding failed to properly quote those arguments, leading to
failures when using quotes in the values used. As the quoting can be
encoding-sensitive, the connection to the backend needs to be taken
before applying the correct quoting.

Author: Michael Paquier
Reviewed-by: Daniel Gustafsson
Discussion: https://postgr.es/m/20200214041004.GB1998@paquier.xyz
Backpatch-through: 9.5

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/008cf040962c98c7c55d54c28dcb43c3c1d83c92

Modified Files
--------------
src/bin/scripts/createdb.c | 29 +++++++++++++++++++----------
src/bin/scripts/t/020_createdb.pl | 26 +++++++++++++++++++++++++-
2 files changed, 44 insertions(+), 11 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2020-02-27 04:03:07 pgsql: Move src/backend/utils/hash/hashfn.c to src/common
Previous Message Peter Geoghegan 2020-02-26 23:16:49 Re: pgsql: Silence compiler warning in nbtinsert.c.