Re: pgsql: createdb: Fix quoting of --encoding, --lc-ctype and --lc-collate

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: createdb: Fix quoting of --encoding, --lc-ctype and --lc-collate
Date: 2020-02-27 04:13:14
Message-ID: CA+TgmoZ6ddh3mHD9gU8DvNYoFmuJaYYn1+4AvZNp25vTdRwCAQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Buildfarm member curculio just failed with this complaint:

# Failed test 'createdb with incorrect --lc-ctype stderr
/(?^s:^createdb: error: database creation failed: ERROR: invalid
locale name)/'
# at t/020_createdb.pl line 43.
# 'createdb: error: database creation failed: ERROR:
new LC_CTYPE (foo'; SELECT '1) is incompatible with the LC_CTYPE of
the template database (C)
# HINT: Use the same LC_CTYPE as in the template database, or use
template0 as template.
# '
# doesn't match '(?^s:^createdb: error: database creation failed:
ERROR: invalid locale name)'
# Looks like you failed 1 test of 22.
[04:39:08] t/020_createdb.pl .........
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/22 subtests

...Robert

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2020-02-27 05:11:12 Re: pgsql: createdb: Fix quoting of --encoding, --lc-ctype and --lc-collate
Previous Message Robert Haas 2020-02-27 04:03:07 pgsql: Move src/backend/utils/hash/hashfn.c to src/common