From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Move declaration of ecpg_gettext() to a saner place. |
Date: | 2019-11-07 19:22:12 |
Message-ID: | E1iSnMC-0006Gr-AA@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Move declaration of ecpg_gettext() to a saner place.
Declaring this in the client-visible header ecpglib.h was a pretty
poor decision. It's not meant to be application-callable (and if
it was, putting it outside the extern "C" { ... } wrapper means
that C++ clients would fail to call it). And the declaration would
not even compile for a client, anyway, since it would not have the
macro pg_attribute_format_arg(). Fortunately, it seems that no
clients have tried to include this header with ENABLE_NLS defined,
or we'd have gotten complaints about that. But we have no business
putting such a restriction on client code.
Move the declaration to ecpglib_extern.h, since in fact nothing
outside src/interfaces/ecpg/ecpglib/ needs to call it.
The practical effect of this is just that clients can now safely
#include ecpglib.h while having ENABLE_NLS defined, but that seems
like enough of a reason to back-patch it.
Discussion: https://postgr.es/m/20590.1573069709@sss.pgh.pa.us
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/831ca9513c59436831265e7198e23639120704be
Modified Files
--------------
src/interfaces/ecpg/ecpglib/extern.h | 6 ++++++
src/interfaces/ecpg/include/ecpglib.h | 6 ------
2 files changed, 6 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2019-11-07 20:50:07 | pgsql: docs: clarify that only INSERT and UPDATE triggers can mod. NEW |
Previous Message | David Steele | 2019-11-07 17:33:33 | Re: pgsql: doc: Further clarify how recovery target parameters are applied |