| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: doc: Further clarify how recovery target parameters are applied |
| Date: | 2019-11-07 17:33:33 |
| Message-ID: | 8bd7266c-f720-1eda-c94e-77e815768b7b@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 11/6/19 4:49 AM, Fujii Masao wrote:
> On Wed, Nov 6, 2019 at 4:29 PM Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>>
>> On 2019-11-06 05:48, Fujii Masao wrote:
>>> Patch attached. As I argued upthread, IMO it's better to remove
>>> the latter description from the doc and the patch does that.
>>> Also the patch adds "mainly" into the former description.
>>
>> I think we should list explicitly what is applied and what is not. This
>> is the reference documentation after all.
>
> Or it might be better to add something like "This setting has no effect if
> in standby mode / archive recovery" into the description of each parameter,
> instead.
+1. This will probably be easier to maintain and less confusing overall.
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-11-07 19:22:12 | pgsql: Move declaration of ecpg_gettext() to a saner place. |
| Previous Message | Alvaro Herrera | 2019-11-07 17:28:28 | pgsql: Fix SET CONSTRAINTS .. DEFERRED on partitioned tables |