From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Stabilize pg_dump output order for similarly-named triggers and |
Date: | 2019-11-04 21:25:30 |
Message-ID: | E1iRjqs-0003vF-1W@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Stabilize pg_dump output order for similarly-named triggers and policies.
The code only compared two triggers' names and namespaces (the latter
being the owning table's schema). This could result in falling back
to an OID-based sort of similarly-named triggers on different tables.
We prefer to avoid that, so add a comparison of the table names too.
(The sort order is thus table namespace, trigger name, table name,
which is a bit odd, but it doesn't seem worth contorting the code
to work around that.)
Likewise for policy objects, in 9.5 and up.
Complaint and fix by Benjie Gillam. Back-patch to all supported
branches.
Discussion: https://postgr.es/m/CAMThMzEEt2mvBbPgCaZ1Ap1N-moGn=Edxmadddjq89WG4NpPtQ@mail.gmail.com
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ee8b95f2684a2af9a4c3b78b345e01cba2ef31ce
Modified Files
--------------
src/bin/pg_dump/pg_dump_sort.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2019-11-05 00:18:14 | pgsql: Refactor code building relation options |
Previous Message | Tom Lane | 2019-11-04 21:25:29 | pgsql: Stabilize pg_dump output order for similarly-named triggers and |