| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Refactor code building relation options |
| Date: | 2019-11-05 00:18:14 |
| Message-ID: | E1iRmY2-0004gU-61@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Refactor code building relation options
Historically, the code to build relation options has been shaped the
same way in multiple code paths by using a set of datums in input with
the options parsed with a static table which is then filled with the
option values. This introduces a new common routine in reloptions.c to
do most of the legwork for the in-core code paths.
Author: Amit Langote
Reviewed-by: Michael Paquier
Discussion: https://postgr.es/m/CA+HiwqGsoSn_uTPPYT19WrtR7oYpYtv4CdS0xuedTKiHHWuk_g@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3534fa2233285c1fab1e668871aabf05e5541213
Modified Files
--------------
contrib/bloom/blutils.c | 14 +--
src/backend/access/brin/brin.c | 22 +----
src/backend/access/common/reloptions.c | 115 +++++++++++------------
src/backend/access/gin/ginutil.c | 22 +----
src/backend/access/gist/gistutil.c | 22 +----
src/include/access/reloptions.h | 5 +
src/test/modules/dummy_index_am/dummy_index_am.c | 15 +--
7 files changed, 82 insertions(+), 133 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-11-05 01:19:41 | pgsql: Doc: Improve description around ALTER TABLE ATTACH PARTITION |
| Previous Message | Tom Lane | 2019-11-04 21:25:30 | pgsql: Stabilize pg_dump output order for similarly-named triggers and |