From: | Robert Haas <rhaas(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: When performing a base backup, check for read errors. |
Date: | 2019-09-06 13:11:57 |
Message-ID: | E1i6E1t-0004un-CN@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
When performing a base backup, check for read errors.
The old code didn't differentiate between a read error and a
concurrent truncation. fread reports both of these by returning 0;
you have to use feof() or ferror() to distinguish between them,
which this code did not do.
It might be a better idea to use read() rather than fread() here,
so that we can display a less-generic error message, but I'm not
sure that would qualify as a back-patchable bug fix, so just do
this much for now.
Jeevan Chalke, reviewed by Jeevan Ladhe and by me.
Discussion: http://postgr.es/m/CA+TgmobG4ywMzL5oQq2a8YKp8x2p3p1LOMMcGqpS7aekT9+ETA@mail.gmail.com
Branch
------
REL9_4_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/fbe897134801504a3f1240d61cb78a69bc0850a5
Modified Files
--------------
src/backend/replication/basebackup.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-09-06 13:28:56 | Re: pgsql: Doc: remove some long-obsolete information from installation.sgm |
Previous Message | Peter Eisentraut | 2019-09-06 11:53:20 | Re: pgsql: Doc: remove some long-obsolete information from installation.sgm |