From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Remove some useless code |
Date: | 2018-12-31 17:51:03 |
Message-ID: | E1ge1iR-0003tA-VC@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Remove some useless code
In commit 8b08f7d4820f I added member relationId to IndexStmt struct.
I'm now not sure why; DefineIndex doesn't need it, since the relation
OID is passed as a separate argument anyway. Remove it.
Also remove a redundant assignment to the relationId argument (it wasn't
redundant when added by commit e093dcdd285, but should have been removed
in commit 5f173040e3), and use relationId instead of stmt->relation when
locking the relation in the second phase of CREATE INDEX CONCURRENTLY,
which is not only confusing but it means we resolve the name twice for
no reason.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e439c6f0c3ddc6e4b71922ec326cb796c2885656
Modified Files
--------------
src/backend/commands/indexcmds.c | 5 ++---
src/backend/nodes/copyfuncs.c | 1 -
src/backend/nodes/equalfuncs.c | 1 -
src/backend/nodes/outfuncs.c | 1 -
src/backend/parser/gram.y | 2 --
src/backend/parser/parse_utilcmd.c | 1 -
src/include/nodes/parsenodes.h | 1 -
7 files changed, 2 insertions(+), 10 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-12-31 21:38:18 | pgsql: Update leakproofness markings on some btree comparison functions |
Previous Message | Tom Lane | 2018-12-31 17:39:21 | pgsql: Fix oversight in commit b5415e3c2187ab304390524f5ae66b4bd2c58279 |