pgsql: Fix oversight in commit b5415e3c2187ab304390524f5ae66b4bd2c58279

Fix oversight in commit b5415e3c2187ab304390524f5ae66b4bd2c58279.

While rearranging code in tidpath.c, I overlooked the fact that we ought
to check restriction_is_securely_promotable when trying to use a join
clause as a TID qual. Since tideq itself is leakproof, this wouldn't
really allow any interesting leak AFAICT, but it still seems like we
had better check it.

For consistency with the corresponding logic in indxpath.c, also
check rinfo->pseudoconstant. I'm not sure right now that it's
possible for that to be set in a join clause, but if it were,
a match couldn't be made anyway.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b2edbbd02d3070c234225da7b2ec10298652658a

Modified Files
--------------
src/backend/optimizer/path/tidpath.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)