pgsql: Fix issues with TAP tests of pg_verify_checksums

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix issues with TAP tests of pg_verify_checksums
Date: 2018-11-20 01:22:16
Message-ID: E1gOuk4-0001ch-K2@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix issues with TAP tests of pg_verify_checksums

Two issues have been spotted and get fixed here:
- When checking for corrupted files, make sure that pg_verify_checksums
complains about the correct file. In order to make the logic more
robust, all files created are immediately removed once checks on them
are done. The error message generated by pg_verify_checksums also now
includes the file name it sees as corrupted.
- Before running corruption-related tests, empty files are generated
which used names mapping with the corrupted files, potentially leading
to conflicts. So use different set of names for both.

Author: Michael Banck
Discussion: https://postgr.es/m/20181119181119.GC23740@nighthawk.caipicrew.dd-dns.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9685d7383ab48ebe6a6213530f64e4dc67776583

Modified Files
--------------
src/bin/pg_verify_checksums/t/002_actions.pl | 26 +++++++++++++++-----------
1 file changed, 15 insertions(+), 11 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-11-20 01:22:51 Re: pgsql: Add TAP tests for pg_verify_checksums
Previous Message Tom Lane 2018-11-20 01:01:45 pgsql: Fix old TAP tests' method for selecting a valid PGPORT value.