| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Michael Banck <michael(dot)banck(at)credativ(dot)de> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: pgsql: Add TAP tests for pg_verify_checksums |
| Date: | 2018-11-20 01:22:51 |
| Message-ID: | 20181120012251.GF4400@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Nov 19, 2018 at 07:11:19PM +0100, Michael Banck wrote:
> First off, I think those fail_corrupt files should have different
> filenames than the empty ones above (I left `99999_vm.123' as an
> example of a duplicated file).
A comment about that is a good idea. So added.
> So either we remove or truncate the files again after
> $node->command_checks_all(), or the tests use the relfilenode
> feature.
>
> However, in the latter case we would have to use a different main
> relfilenode ID for each subtest, as otherwise pg_verify_checksums would
> again fail on the first file it scans.
The take here is to make sure that the correct file name is showing up
in the produced error message, and removing the files makes future test
more robust, so I have committed a version which removes the files
instead.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-11-20 05:42:19 | pgsql: Refine some guc.c help texts |
| Previous Message | Michael Paquier | 2018-11-20 01:22:16 | pgsql: Fix issues with TAP tests of pg_verify_checksums |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-11-20 01:25:22 | Re: ToDo: show size of partitioned table |
| Previous Message | Andres Freund | 2018-11-20 00:04:55 | Re: Buildfarm failures for hash indexes: buffer leaks |