pgsql: Don't try to test files named with a trailing dot on Windows

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Don't try to test files named with a trailing dot on Windows
Date: 2018-10-21 13:03:35
Message-ID: E1gEDOJ-0000dz-JH@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't try to test files named with a trailing dot on Windows

The pg_verify_checksums test tries to create files with corrupt data
named "123." and "123_." But on Windows a file name with a trailing dot
is the same as a file without the trailing dot. In the first case this
will create a file with a "valid" name, which causes the test to fail in
an unexpected way, and in the secongd case this will be redandant as the
test already creates a file named "123_".

Bug discovered by buildfarm animal bowerbird.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c468bd5c087051e2edc573118a42d73a8ae3c3a4

Modified Files
--------------
src/bin/pg_verify_checksums/t/002_actions.pl | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-10-21 13:51:52 Re: pgsql: Don't try to test files named with a trailing dot on Windows
Previous Message Andrew Dunstan 2018-10-21 12:18:14 Re: pgsql: Silence perlcritic warning about missing return.