Re: pgsql: Don't try to test files named with a trailing dot on Windows

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Don't try to test files named with a trailing dot on Windows
Date: 2018-10-21 13:51:52
Message-ID: 20181021135152.GB14282@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, Oct 21, 2018 at 01:03:35PM +0000, Andrew Dunstan wrote:
> Don't try to test files named with a trailing dot on Windows
>
> The pg_verify_checksums test tries to create files with corrupt data
> named "123." and "123_." But on Windows a file name with a trailing dot
> is the same as a file without the trailing dot. In the first case this
> will create a file with a "valid" name, which causes the test to fail in
> an unexpected way, and in the secongd case this will be redandant as the
> test already creates a file named "123_".
>
> Bug discovered by buildfarm animal bowerbird.

Thanks Andrew! That property of Windows is actually... Interesting.
Please feel free to ping me on the involved message if I don't see a
buildfarm failure, and I'll investigate.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2018-10-21 21:29:56 pgsql: Fix some grammar errors in bloom.sgml
Previous Message Andrew Dunstan 2018-10-21 13:03:35 pgsql: Don't try to test files named with a trailing dot on Windows