| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | pgadmin-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | pgAdmin 4 commit: Code refactoring: |
| Date: | 2018-10-08 10:09:53 |
| Message-ID: | E1g9SU5-0006a9-DK@gothos.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Code refactoring:
- Move the duplicate code for closing the background process dialog into 'test_gui_helper.py',
- Simplify the logic by removing the duplicate steps to insert/update binary paths for each server type from 'test_utils.py'.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0f1651686b28b776265b829e8999e4287d8c3b29
Author: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
Modified Files
--------------
.../pg_utilities_backup_restore_test.py | 27 +--------
.../feature_tests/pg_utilities_maintenance_test.py | 25 +-------
.../python_test_utils/test_gui_helper.py | 38 ++++++++++++
web/regression/python_test_utils/test_utils.py | 67 ++++++----------------
4 files changed, 61 insertions(+), 96 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2018-10-08 10:10:01 | Re: [pgAdmin4][Patch]: Code refactoring |
| Previous Message | Dave Page | 2018-10-08 09:03:31 | Re: [pgAdmin4][Patch]: RM 1253 - Store and reload current location in treeview |