| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: Code refactoring |
| Date: | 2018-10-08 10:10:01 |
| Message-ID: | CA+OCxowdwfpyiwmq=J+DfT4H6i55bJwfySMnbJhtH=YpBQj2tg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Thanks, patch applied.
On Fri, Oct 5, 2018 at 7:56 AM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> +++
>
> Below are the changes,
> - Move the duplicate code for closing the background process dialog into
> 'test_gui_helper.py',
> - Simplify the logic by removing the duplicate steps to insert/update
> binary paths for each server type from 'test_utils.py'.
>
>
> On Thu, Oct 4, 2018 at 9:35 PM Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> PFA patch with some code refactoring.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2018-10-08 10:16:56 | Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions |
| Previous Message | Dave Page | 2018-10-08 10:09:53 | pgAdmin 4 commit: Code refactoring: |