pgsql: Refactor relation opening for VACUUM and ANALYZE

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Refactor relation opening for VACUUM and ANALYZE
Date: 2018-10-02 00:01:24
Message-ID: E1g787w-0005YH-Si@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Refactor relation opening for VACUUM and ANALYZE

VACUUM and ANALYZE share similar logic when it comes to opening a
relation to work on in terms of how the relation is opened, in which
order locks are tried and how logs should be generated when something
does not work as expected.

This commit refactors things so as both use the same code path to handle
the way a relation is opened, so as the integration of new options
becomes easier.

Author: Michael Paquier
Reviewed-by: Nathan Bossart
Discussion: https://postgr.es/m/20180927075152.GT1659@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e3a25ab9ea56ac540dc683cdf6f6a4b923bd22be

Modified Files
--------------
src/backend/commands/analyze.c | 55 ++------------
src/backend/commands/vacuum.c | 169 ++++++++++++++++++++++++++---------------
src/include/commands/vacuum.h | 2 +
3 files changed, 117 insertions(+), 109 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-10-02 00:11:51 Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru
Previous Message Tom Lane 2018-10-01 23:43:21 Re: pgsql: Create an RTE field to record the query's lock mode for each rel