Re: pgsql: Create an RTE field to record the query's lock mode for each rel

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Create an RTE field to record the query's lock mode for each rel
Date: 2018-10-01 23:43:21
Message-ID: 4015.1538437401@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2018-09-30 17:55:57 +0000, Tom Lane wrote:
>> Create an RTE field to record the query's lock mode for each relation.

> This triggers a new warning for me, when building without asserts:

> /home/andres/src/postgresql/src/backend/executor/execMain.c: In function ‘InitPlan’:
> /home/andres/src/postgresql/src/backend/executor/execMain.c:963:12: warning: variable ‘rellockmode’ set but not used [-Wunused-but-set-variable]
> LOCKMODE rellockmode;
> ^~~~~~~~~~~

Yeah, I knew it would do that. I didn't think it was worth working
around, because that issue will go away in the next phase of the
patch (probably tomorrow).

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-10-02 00:01:24 pgsql: Refactor relation opening for VACUUM and ANALYZE
Previous Message Andres Freund 2018-10-01 23:37:36 Re: pgsql: Create an RTE field to record the query's lock mode for each rel