pgsql: Rationalize Query_for_list_of_[relations] query names in tab-com

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Rationalize Query_for_list_of_[relations] query names in tab-com
Date: 2018-09-21 16:41:07
Message-ID: E1g3OUN-0004N7-Cz@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Rationalize Query_for_list_of_[relations] query names in tab-complete.c.

The previous convention was to use names based on the set of relkinds being
selected for, which was not at all helpful for maintenance, especially
since people had been quite inconsistent about whether to change the names
when they changed the relkinds being selected for. Instead, use names
based on the functionality we need the relation to have, following the
model established by Query_for_list_of_updatables.

While at it, sort the list of Query constants a bit better; it had the
distinct air of code-assembled-by-dartboard before.

Discussion: https://postgr.es/m/14830.1537481254@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e3b7a6d165d42b59b2432c415d7e4a284a645e89

Modified Files
--------------
src/bin/psql/tab-complete.c | 132 ++++++++++++++++++++++++--------------------
1 file changed, 71 insertions(+), 61 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2018-09-21 16:46:50 Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru
Previous Message Thomas Munro 2018-09-21 12:53:32 pgsql: Use size_t consistently in dsa.{ch}.