Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru
Date: 2018-09-21 16:46:50
Message-ID: CA+Tgmoa7JJG0g2rCR=m8wXzExZDBpHPo04a5FyV-EotknVDONg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Sep 14, 2018 at 11:35 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> On 2018-Sep-13, Michael Paquier wrote:
>> Improve autovacuum logging for aggressive and anti-wraparound runs
>>
>> A log message was being generated when log_min_duration is reached for
>> autovacuum on a given relation to indicate if it was an aggressive run,
>> and missed the point of mentioning if it is doing an anti-wrapround
>> run. The log message generated is improved so as one, both or no extra
>> details are added depending on the option set.
>
> Hmm, can a for-wraparound vacuum really not be aggressive? I think one
> of those four cases is really dead code.

My first question was whether TWO of them were dead code ... isn't an
aggressive vacuum to prevent wraparound, and a vacuum to prevent
wraparound aggressive?

I can't figure out what this is giving us that we didn't have before.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Sergei Kornilov 2018-09-21 17:38:16 Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru
Previous Message Tom Lane 2018-09-21 16:41:07 pgsql: Rationalize Query_for_list_of_[relations] query names in tab-com

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2018-09-21 17:29:02 Re: proposal: prefix function
Previous Message Enrique Escobar 2018-09-21 16:25:31 RE: impact of SPECTRE and MELTDOWN patches