From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Improve English wording of some other getObjectDescription() mes |
Date: | 2018-05-24 18:01:15 |
Message-ID: | E1fLuY7-0001lo-31@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve English wording of some other getObjectDescription() messages.
Print columns as "column C of <relation>" rather than "<relation> column
C". This seems to read noticeably better in English, as evidenced by the
regression test output changes, and the code change also makes it possible
for translators to adjust the phrase order in other languages.
Also change the output for OCLASS_DEFAULT from "default for %s" to
"default value for %s". This seems to read better and is also more
consistent with the output of, for instance, getObjectTypeDescription().
Kyotaro Horiguchi, per a complaint from me
Discussion: https://postgr.es/m/20180522.182020.114074746.horiguchi.kyotaro@lab.ntt.co.jp
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b86b7bfa3e8b3e4255352ca564b3f1270e708274
Modified Files
--------------
contrib/earthdistance/expected/earthdistance.out | 8 ++++----
contrib/postgres_fdw/expected/postgres_fdw.out | 2 +-
src/backend/catalog/objectaddress.c | 22 +++++++++++++++++-----
src/test/regress/expected/alter_table.out | 6 +++---
src/test/regress/expected/collate.out | 2 +-
src/test/regress/expected/domain.out | 8 ++++----
src/test/regress/expected/sequence.out | 4 ++--
src/test/regress/expected/triggers.out | 8 ++++----
8 files changed, 36 insertions(+), 24 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-05-24 20:11:31 | pgsql: Update sepgsql regression test output for getObjectDescription() |
Previous Message | Tom Lane | 2018-05-24 17:20:23 | pgsql: Improve translatability of some getObjectDescription() messages. |