From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: MERGE post-commit review |
Date: | 2018-04-05 08:56:36 |
Message-ID: | E1f40hA-0000Rt-LK@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
MERGE post-commit review
Review comments from Andres Freund
* Consolidate code into AfterTriggerGetTransitionTable()
* Rename nodeMerge.c to execMerge.c
* Rename nodeMerge.h to execMerge.h
* Move MERGE handling in ExecInitModifyTable()
into a execMerge.c ExecInitMerge()
* Move mt_merge_subcommands flags into execMerge.h
* Rename opt_and_condition to opt_merge_when_and_condition
* Wordsmith various comments
Author: Pavan Deolasee
Reviewer: Simon Riggs
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4b2d44031f8c005f6f86364d7663858b6b5bdd14
Modified Files
--------------
src/backend/commands/trigger.c | 192 ++++++++------
src/backend/executor/Makefile | 4 +-
src/backend/executor/README | 11 +-
src/backend/executor/{nodeMerge.c => execMerge.c} | 302 +++++++++++++++-------
src/backend/executor/execPartition.c | 9 +-
src/backend/executor/nodeModifyTable.c | 109 +-------
src/backend/optimizer/plan/setrefs.c | 16 +-
src/backend/parser/gram.y | 12 +-
src/include/executor/execMerge.h | 31 +++
src/include/executor/nodeMerge.h | 22 --
src/include/executor/nodeModifyTable.h | 1 +
11 files changed, 384 insertions(+), 325 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Teodor Sigaev | 2018-04-05 10:04:50 | pgsql: Fix typo |
Previous Message | Peter Geoghegan | 2018-04-05 03:35:32 | Re: pgsql: Skip full index scan during cleanup of B-tree indexes when possi |